Space in file names is no longer re-written when uploading

agata
Topic Author
Offline
Elite Member

3 years 4 months ago - 3 years 4 months ago #79582 by agata

Replied by agata on topic Space in file names is no longer re-written when uploading

Hello,
Does this mean you're not going to be rewriting spaces to - or is there a new release I failed to find that fixes this? Latest release on Github is from October.
Best,
Agata

Last edit: 3 years 4 months ago by ggppdk.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

3 years 4 months ago #79587 by ggppdk

Replied by ggppdk on topic Space in file names is no longer re-written when uploading

Hello

yes allowing spaces was intentional
do you use these in some custom code ?

you should encode filename in URLs always

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

agata
Topic Author
Offline
Elite Member

3 years 4 months ago #79591 by agata

Replied by agata on topic Space in file names is no longer re-written when uploading

Hello,
Since the filenames used to be rewritten I wasn't URL encoding every image. It does break things with responsive images as image paths aren't always wrapped in quote marks and then new images ended up falling back on the smallest size. Spaces being rewritten is standard in Joomla itself (and Wordpress too) and I don't quite see the purpose of introducing a breaking change like this, could this at least be an option in configuration to turn rewriting spaces and other special characters on and off?
Best,
Agata

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

3 years 4 months ago #79607 by ggppdk

Replied by ggppdk on topic Space in file names is no longer re-written when uploading

Hello

i will review this

you are uploading via image - gallery field and the field's display is broken or you are using the filenames in custom code ?

Please Log in or Create an account to join the conversation.

agata
Topic Author
Offline
Elite Member

3 years 4 months ago - 3 years 4 months ago #79614 by agata

Replied by agata on topic Space in file names is no longer re-written when uploading

Hello,
Here's an example of the rendered source:

Code:

<img src="/images/stories/flexicontent/m_fld61_2bh.090 borde hill rose garden.jpg"
data-src="/images/stories/flexicontent/m_fld61_2bh.090 borde hill rose garden.jpg"
data-srcset="/images/stories/flexicontent/l_fld61_2bh.090 borde hill rose garden.jpg 600w, /images/stories/flexicontent/m_fld61_2bh.090 borde hill rose garden.jpg 300w"
sizes="(min-width: 980px) 50vw, 100vw"
alt=""
class="c-tour__image u-margin-bottom c-tour__image--desk u-hidden-until@desktop lazyload"
itemprop="image"
srcset="https://tours-international.com/images/stories/flexicontent/m_fld61_2bh.090 /borde /hill /rose /garden.jpg 300w, https://tours-international.com/images/stories/flexicontent/s_fld61_2bh.090 /borde /hill /rose /garden.jpg 720w"
sizes="(min-width: 300px) 300px, (min-width: 720px) 720px"  />

As you can see, spaces in the file names will cause this to not work as intended.
Thanks,
Agata

Last edit: 3 years 4 months ago by agata.

Please Log in or Create an account to join the conversation.