Flexicontent HTML5 Header Tag Error

More
12 years 7 months ago #30325 by ggppdk
Rehne, i think since maybe you should get SVN access for updating the template code.

Recently (some revisions after r1514) i have unified JS some templates code and moved it outside of the templates.

Also default/presentation/tabbed template have the same item.php (a "modular" item layout) so i think to replace them with an "include" statement ?


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

More
12 years 7 months ago #30328 by Rehne

ggppdk wrote: Rehne, i think since maybe you should get SVN access for updating the template code.

ok ... i would like to do

ggppdk wrote: Recently (some revisions after r1514) i have unified JS some templates code and moved it outside of the templates.

Yes ... i have seen that
i'm working locally always with the latest SVN version ... to find bugs ;)
therefore i write the version nr. (r15xx) to my uploads or name it so

ggppdk wrote: Also default/presentation/tabbed template have the same item.php (a "modular" item layout) so i think to replace them with an "include" statement ?

mmmm ... i think that is maybe not so good
it is then probably more difficult for unexperienced users to use the template as model for there own templates ... mmm

Regards

Please Log in or Create an account to join the conversation.

More
12 years 7 months ago #30330 by ggppdk
Using the latest SVN template version is extra work for you,
and i have seen that you do,
thanks,

my comments was about trying to minimize places needed to be updated.

(e.g. also all advanced search index code of plugins has been unified in r1528, these were an important reason for delaying final release to have a solid interface and CORE on which to work and provide documentation)

Rehne wrote:

ggppdk wrote: Also default/presentation/tabbed template have the same item.php (a "modular" item layout) so i think to replace them with an "include" statement ?

mmmm ... i think that is maybe not so good
it is then probably more difficult for unexperienced users to use the template as model for there own templates ... mmm

Regards


Actually for inexperienced users we will include a comment above the include statement, asking them "to copy paste this file here" in order to customize it ;)


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

More
12 years 7 months ago #30332 by Rehne

ggppdk wrote: my comments was about trying to minimize places needed to be updated.

i know ;)
Accordingly to that, in the item-tabbed-accordion template, i no longer divided in xhtml and html5 files in ...

ggppdk wrote: Actually for inexperienced users we will include a comment above the include statement, asking them "to copy paste this file here" in order to customize it ;)

ok
that would be an idea (should be provide in different languages)

Regards

Please Log in or Create an account to join the conversation.

More
12 years 7 months ago #30523 by ggppdk
Hello, I have corrected these and a couple of other minor things in the templates, it is on SVN


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

More
12 years 7 months ago #30536 by Rehne

ggppdk wrote: Hello, I have corrected these and a couple of other minor things in the templates, it is on SVN


i've seen it ... thanks
but I recommend instead of using
Code:
</h<?php echo $itemTitleHeaderLevel; ?>> </h<?php echo $tabsHeaderLevel; ?>> </h<?php echo $catTitleHeaderLevel; ?>>
to use this spelling
Code:
<?php echo '</h'.$itemTitleHeaderLevel.'>'."\n"; ?> <?php echo '</h'.tabsHeaderLevel.'>'."\n"; ?> <?php echo '</h'.catTitleHeaderLevel.'>'."\n"; ?>

because I made the experience that Some editors like Dreamweaver will automatically set a closing tag > after </h when opening the document.

Regards

Please Log in or Create an account to join the conversation.

Moderators: vistamediajoomlacornerggppdk
Time to create page: 0.644 seconds
Cookies user preferences
We use cookies to ensure you to get the best experience on our website. If you decline the use of cookies, this website may not function as expected.
Accept all
Decline all
Essential
These cookies are needed to make the website work correctly. You can not disable them.
Display
Accept
Analytics
Tools used to analyze the data to measure the effectiveness of a website and to understand how it works.
Google Analytics
Accept
Decline
Save