FC2 - R1492 - mistake in new simple tabbed positions code

Hi George,

i'm testing the new opportunity with the simple tabbed positions
2 minor issues sneaked into the HTML code

for example in the default Template
intem.php on line 138 i thought class='".$class."' must be delete
and then either
intem.php on line 277 must be delete also because there is a closing div too much

as I see it, this applies to all
faq, default, presentation and to category layout

By the way, a question:
why do you use sometime simple quotes
e.g. <div class='fctabber'
instead of double quotes
could it be that this will lead to problems
perhaps in certain browsers ???

And another thing
I am just starting to prepare the standard FlexiContent Templates for HTML5.
I think it would be handy to the user give them a choice in the template settings: HTML mode: xhtml or html5
What do you think?
I would prepare and provide it!


Regards

mmm, thanks for pointing out the div closing div,

about single quotes there having been quite a few discussions on the topic, they work with HTML and are allow by XHTML standard, of course someone could make a custom browser that will not work with single quotes , but since no reason to be single quotes there i ll change this

about the creation of the tabs i think to remove all this TABBING duplicate code and add a loop to create it? or this will limit customization?

Hi,

ggppdk wrote: mmm, thanks for pointing out the div closing div,

thanks for the new tab function

ggppdk wrote: about single quotes there having been quite a few discussions on the topic, they work with HTML and are allow by XHTML standard, of course someone could make a custom browser that will not work with single quotes , but since no reason to be single quotes there i ll change this

ok ...
for me ... it confuses me a bit
e.g. because i think always of PHP when i see single quotes

ggppdk wrote: about the creation of the tabs i think to remove all this TABBING duplicate code and add a loop to create it? or this will limit customization?

mmm ... i'm not sure ... but I do not think
...
+ then there is only one template position for the tabs
where to position the fields that are displayed as tabs ... so more than 6 tabs are possible ... great
-+ BUT how it looks with the titles of tabs ... currently i can give for each tab a custom title (great) ... with the loop creation it will be the field label?! mmm not so good ... or is there a possibility for custom titles too?

good enhancement would be:
1. css3 tabs ... if javascript is not available (or vice versa) ... like this one css-tricks.com/css3-tabs/
2. choice whether to display as tabs or slider or extra position(s) for slider ... (i think the slider is very similar to the tabs)


a question:
why becomes the '#flexicontent .fctabber' in the current implementation the flexicontent.css the width 5000px and not 100%?

Regards

1. Corrected the new tabbing code in the templates:
- removed extra div closed
- used double quotes (although i still think this is not important for any browser)
- removed the meaningless $class

-- (b) Added one more tab row at about bottom

2. In backend Field position editing:
-- (a) added display of backend as of tabs in a single row to be more intuitive to the user
-- (b) hide groupmarker fields, to avoid confusion

3. Added the new template items-tabbed to create a category view with all items of the current page placed inside TABs

4. Changed the code to tabbing code to use loop


You asked about title label of the tabs when using loop


actually it simple ... just use: then in the new code change line: $tabpos_label = ...; , to be: similar things can be done for other customizations e.g.
Regards

Hi,

1. ... , 2. ... , 3. ... , 4 .... and
You asked about title label of the tabs when using loop ...

great ... solution ... thanks :!:
i will download and test it

what do you think about
good enhancement would be:
1. css3 tabs ... if javascript is not available (or vice versa) ... like this one css-tricks.com/css3-tabs/
2. choice whether to display as tabs or slider or extra position(s) for slider ... (i think the slider is very similar to the tabs)

Regards

sure, for future update