Open menu

Deleting items, image/gallery field needs to remove images

igcorreia
Topic Author
Offline
Platinum Member

11 years 9 months ago #40062 by igcorreia

Deleting items, image/gallery field needs to remove images was created by igcorreia

When I delete 1000 items does flexi also delete the images and downloads from that are from this items?

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

11 years 9 months ago #40066 by ggppdk

Replied by ggppdk on topic Deleting items, image/gallery field needs to remove images

Hello

FLEXIcontent has event function onBeforeDeleteField,

this function is called during CONTENT Item deletion,
.. but currently it is empty for image field !

-- for image fields in folder mode , it should delete the folder with the images, but this was missed

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

igcorreia
Topic Author
Offline
Platinum Member

11 years 9 months ago #40067 by igcorreia

Replied by igcorreia on topic Deleting items, image/gallery field needs to remove images

I see, I notice because I was trying to gain disc space from a large site and when I deleted it nothing change

Take this as a feature request.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

11 years 9 months ago #40068 by ggppdk

Replied by ggppdk on topic Deleting items, image/gallery field needs to remove images

Hello,

actually deleting folder image filed in folder mode is only a few lines of code,
AND since images are not reusable they should really be deleted:

(if you would want to use now)

Code:

// Method called just before the item is deleted to remove custom item data related to the field
function onBeforeDeleteField(&$field, &$item) {
	$image_source = $field->parameters->get('image_source', 0);
	$dir = $field->parameters->get('dir');
	if ($image_source) {
		jimport('joomla.filesystem.file');
		jimport('joomla.filesystem.folder');
		jimport('joomla.filesystem.jpath');
		
		// Delete image folder if it exists
		$destpath = JPath::clean( JPATH_SITE .DS. $dir . DS. 'item_'.$field->item_id   . '_field_'.$field->id .DS);
		if ( JFolder::exists($destpath) && !JFolder::delete($destpath) ) {
			JError::raiseNotice(100, $field->label .': Notice: Unable to delete folder: '. $destpath );
			return false;
		}
	}
}

Please Log in or Create an account to join the conversation.

igcorreia
Topic Author
Offline
Platinum Member

11 years 9 months ago #40069 by igcorreia

Replied by igcorreia on topic Deleting items, image/gallery field needs to remove images

It is too late I have already delete the items i cannot bring them back

Thanks.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

11 years 9 months ago #40093 by ggppdk

Replied by ggppdk on topic Deleting items, image/gallery field needs to remove images

Hello,

anyway, thanks for noting this

as this code was missing, we added it
(will be in next public package)

this is more like a bug than a feature since these images are not reused (when image/gallery field is in folder mode) so keeping them is erroneous

Please Log in or Create an account to join the conversation.