[fixed r1366] FC content module bug with "Tags scope"

hede
Topic Author
Offline
Platinum Member

13 years 7 months ago - 13 years 6 months ago #26080 by hede

[fixed r1366] FC content module bug with "Tags scope" was created by hede

When using the "Tags scope" the module displays all items but the one with the tag set in the module.

All turns out well as soon as there are at least two items with that tag. ... damn! four hours lost in bug land ... malesh

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Last edit: 13 years 6 months ago by hede.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 7 months ago #26134 by ggppdk

Replied by ggppdk on topic [fixed r1366] FC content module bug with "Tags scope"

Indeed, the "Related Items" feature of ITEMS SCOPE excludes the currently displayed item from the related items listing,
... in both case of related items via (a) tags or via (b) related items field

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star review. Thanks!

Please Log in or Create an account to join the conversation.

hede
Topic Author
Offline
Platinum Member

13 years 7 months ago #26143 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

That's weird. I didn't touch anything in Item Scope. It is set to "All" - how can there be limitation of items displayed?

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 7 months ago #26145 by ggppdk

Replied by ggppdk on topic [fixed r1366] FC content module bug with "Tags scope"

hede wrote: When using the "Tags scope" the module displays all items but the one with the tag set in the module.

What do with "the one" (item)? which item? the current item?

"item with tag set" ??

Please Log in or Create an account to join the conversation.

hede
Topic Author
Offline
Platinum Member

13 years 7 months ago #26155 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

Maybe I need to rephrase that:
Tags scope(not relatet Items scope): Imagine there are 3 tags. Tag one has 4 items, Tag two has 1 item, Tag three has 5 items. You click on the second one that is assigned to only a one single item. You check the module output. You see that instead of displaying the one item that is assigned to the second tag, the nine items are displayed that belong to the first and third Tag.
When you then assign another item to the second Tag, all turns out well and only those two items are displayed.

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 7 months ago #26285 by ggppdk

Replied by ggppdk on topic [fixed r1366] FC content module bug with "Tags scope"

Fixed in r1351

Please Log in or Create an account to join the conversation.

hede
Topic Author
Offline
Platinum Member

13 years 7 months ago #26468 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

Thanks. Works great.

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

hede
Topic Author
Offline
Platinum Member

13 years 6 months ago #26562 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

Since around r1363 the old behavior is back - if there is only one single item with the tag the module goes crazy and displays all items with all the other tags except the one with the specified tag (as descriped above).

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 6 months ago #26571 by ggppdk

Replied by ggppdk on topic [fixed r1366] FC content module bug with "Tags scope"

I think it was never fixed 100%, i found the problem: = AND <> are reversed when there is a single item

In modules/mod_flexicontent/helper.php
Find lines:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];

and replace with:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];

I will commit the fix

Please Log in or Create an account to join the conversation.