small conceptual bug in content module

modules\mod_flexicontent\tmpl\news.php

Line 282: <p class="news_text">

should be: <div class="news_text">

Because the specs say "block elements are not allowed within p". Meaning you can technically not place a <h2> in the description text of an article that is displayed by the content module. With the consequence that e.g. Chrome closes the p after the first opening p in your description and therefore adds an additional <p></p> at the end of your description content which screws up your layout.

this <p>...</p> USUALLY contain text stripped of HTML
the ability not to strip text was added later after user request. In general you should strip text.

now our p is inside a span which is normally not allowed, but then if we replace it with a div div is also not allowed inside a span

Thinking of the fact that we added ability not strip HTML maybe we should replace p and all span should be replaced with div

Yes, that would suit all possible situations I think. Great!

ggppdk wrote: Thinking of the fact that we added ability not strip HTML maybe we should replace p and all span should be replaced with div

This seems to be OK without any other CSS changes, did you test it?

I cant tell in general but divs suit my css. But I use an override for the news.php anyway.

It may effect someone who specified classes in css like span.xxxxxxx but most people will probably use .xxxxxxx, so making all spans to divs will do very little damage and even if it is easy to fix.

Committed this in r1350