Open menu

[fixed r1366] Scope by Tag

igcorreia
Topic Author
Offline
Platinum Member

12 years 11 months ago #26393 by igcorreia

[fixed r1366] Scope by Tag was created by igcorreia

is scope by tag working properly?

j1.5 yestarday last svn.

Please Log in or Create an account to join the conversation.

igcorreia
Topic Author
Offline
Platinum Member

12 years 11 months ago #26394 by igcorreia

Replied by igcorreia on topic [fixed r1366] Scope by Tag

we think INCLUDE / EXCLUDE are inverted please confirm.

Please Log in or Create an account to join the conversation.

igcorreia
Topic Author
Offline
Platinum Member

12 years 11 months ago #26395 by igcorreia

Replied by igcorreia on topic [fixed r1366] Scope by Tag

the last post was happening becouse we only had 1 item assign to that TAG.

But if we assign 2 items to that tag we EXCLUDE / INLCUDe will work properly.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

12 years 11 months ago #26574 by ggppdk

Replied by ggppdk on topic [fixed r1366] Scope by Tag

I found the problem: = AND <> are reversed when there is a single item

In modules/mod_flexicontent/helper.php
Find lines:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];

and replace with:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];

I will commit the fix

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.