Bug: Translation / Copying loses 0 fields

Hello

the translation / copying function has a bug.

Checkbox fields or other fields which have field values or check box item index of false or 0 do not get copied.

This is due to the php empty check here which treats 0 / false as empty, the empty check should be removed:


foreach($fields as $field)
{
if (!empty($field->value)) {
$query = 'INSERT INTO #__flexicontent_fields_item_relations (`field_id`, `item
_id`, `valueorder`, `value`)'
.' VALUES(' . $field->field_id . ', ' . $copyid . ', ' . $field
->valueorder . ', ' . $this->_db->Quote($field->value) . ')'
;
$this->_db->setQuery($query);
$this->_db->query();
}
}

Please fix

Cheers

Geejay

thanks for return

Hello

replaced it with

if (strlen($field->value)) {...}

thanks for report

Regards

Hi,

btw, there seem to be plenty of such empty checks in the code.

Cheers

Geejay

Hello

yes,
there are legitimate and correct unless otherwise proven

Regards