[solved] html5 output not valid

More
10 years 11 months ago - 10 years 11 months ago #48087 by gcprnet
I just copied the blog template from FC version 2.2.0 r1910 in order to completely re-write my category output. When I opened the page source in firefox, i noticed the output of firebug's html validator that showed lots of errors. I was working in 'category_items_html5.php'. Reviewing the code I found that around line 495 instead of closing the <header> tag it was opened again. So I changed
Code:
<?php if ( $header_shown ) : ?> <header class="group"> <?php endif; ?>
to
Code:
<?php if ( $header_shown ) : ?> </header> <?php endif; ?>
which seems to have fixed most of the html errors
Last edit: 10 years 11 months ago by gcprnet.

Please Log in or Create an account to join the conversation.

More
10 years 11 months ago #48091 by ggppdk
Hello

about validation,

1. about backend

we have validated all backend pages to be XHTML valid (if ones modifies the backend e.g. via a system plugin to add JS inside CDATA then most pages will 100% XHTML valid)

(some are not 100% but they do not have mismatched HTML tags)



2. about frontend,
tried to check frontend html, but it seems we have missed this one, we will revise HTML css for our built-in template in v2.3.0


what you mention is an important one (mismatched HTML tag), and it is in the
- blog template
- when HTML5 output is enabled
(you have not mention which frontend FLEXIcontent template has this issue but we found it in the blog template)

fix will be in next commit

thanks for feedback


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

More
10 years 11 months ago #48117 by gcprnet
Sorry for not mentioning that it was the blog template, it indeed would have been a valuable information for a bug report :oops:
I hope it was helpful nevertheless :)

Please Log in or Create an account to join the conversation.

Moderators: vistamediajoomlacornerggppdk
Time to create page: 0.321 seconds
Cookies user preferences
We use cookies to ensure you to get the best experience on our website. If you decline the use of cookies, this website may not function as expected.
Accept all
Decline all
Essential
These cookies are needed to make the website work correctly. You can not disable them.
Display
Accept
Analytics
Tools used to analyze the data to measure the effectiveness of a website and to understand how it works.
Google Analytics
Accept
Decline
Save