Strict HTML error in text fields

mcmurdok
Topic Author
Offline
Senior Member

3 years 1 week ago #83336 by mcmurdok

Strict HTML error in text fields was created by mcmurdok

If I use the Server-Side validation in fc text fields and choose "SAFE HTML : remove dangerous tags/attributes" I get an error:

Code:

0 - Joomla\Filter\InputFilter::__construct(): Argument #1 ($tagsArray) must be of type array, null given, called in www/libraries/src/Filter/InputFilter.php on line 69

I think it's related to github.com/joomla/joomla-cms/pull/28946
I changed /components/com_flexicontent/classes/helpers/html.php in line 2122 from

Code:

$safeHtmlFilter = JFilterInput::getInstance(null, null, 1, 1);

Code:

$safeHtmlFilter = InputFilter::getInstance([], [], InputFilter::TAGS_BLACKLIST, InputFilter::ATTR_BLACKLIST);

and add:

Code:

use Joomla\CMS\Filter\InputFilter;

But I could couldn't get it to work.

Any ideas?

Regards

Please Log in or Create an account to join the conversation.

micker
Offline
Administrator

3 years 1 week ago #83338 by micker

Replied by micker on topic Strict HTML error in text fields

hello i think its already corrected
github.com/FLEXIcontent/flexicontent-cck...bcac1f68afab17e0f728
can you confirm it ?

FLEXIcontent is Free but involves a very big effort on our part.
Like the our support? (for a bug-free FC, despite being huge extension) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing reviews. Thanks![/size]

Please Log in or Create an account to join the conversation.

mcmurdok
Topic Author
Offline
Senior Member

3 years 1 week ago - 3 years 1 week ago #83380 by mcmurdok

Replied by mcmurdok on topic Strict HTML error in text fields

Hi micker,
for textarea fields you fixed it. But for text fields, which call the following file:

Code:

4 Joomla\CMS\Filter\InputFilter::getInstance() JROOT/components/com_flexicontent/classes/helpers/html.php:2122
5 flexicontent_html::dataFilter() JROOT/plugins/flexicontent_fields/text/text.php:790

it isn't fixed.

By changing

Code:

JROOT/components/com_flexicontent/classes/helpers/html.php

Line: 2122
from:

Code:

 $safeHtmlFilter = JFilterInput::getInstance(null, null, 1, 1);

to:

Code:

 $safeHtmlFilter = JFilterInput::getInstance(, , 1, 1);

it's working
Regards

Last edit: 3 years 1 week ago by mcmurdok.

Please Log in or Create an account to join the conversation.

micker
Offline
Administrator

3 years 1 week ago #83381 by micker

Replied by micker on topic Strict HTML error in text fields

yes commited

Please Log in or Create an account to join the conversation.

bytekultur
Offline
Premium Member

3 years 1 week ago - 3 years 1 week ago #83394 by bytekultur

Replied by bytekultur on topic Strict HTML error in text fields

I found this line with file search in the following flexicontent fields plugins:

plugins\flexicontent_fields\termlist\termlist.php
plugins\flexicontent_fields\text\text.php
plugins\flexicontent_fields\textarea\textarea.php

as well as in:

components\com_flexicontent\classes\helpers\html.php

In all cases, just use

Code:

$safeHtmlFilter = JFilterInput::getInstance([], [], 1, 1);

Code:

$safeHtmlFilter = JFilterInput::getInstance(array(), array(), 1, 1);

Last edit: 3 years 1 week ago by bytekultur.

Please Log in or Create an account to join the conversation.

micker
Offline
Administrator

3 years 1 week ago #83396 by micker

Replied by micker on topic Strict HTML error in text fields

correct thanks

Please Log in or Create an account to join the conversation.

bytekultur
Offline
Premium Member

3 years 5 days ago #83399 by bytekultur

Replied by bytekultur on topic Strict HTML error in text fields

I can see with the latest update to FlexiContent 4.1.5, the one InputFilter bug in the textarea field plugin was corrected, but not the other ones - the code was still with "null" in the helper class as well as in text and termslist plugin.

Also, I have another Filtering Issue which I've reported separately but could be linked: www.flexicontent.org/forum/29-bug-report...n-editor-fields.html

Please Log in or Create an account to join the conversation.