[solved] Where is the Custom Image Source

mcmurdok
Topic Author
Offline
Senior Member

13 years 10 months ago #23634 by mcmurdok

[solved] Where is the Custom Image Source was created by mcmurdok

After the Update RC4 I'm missing the "Custom Image Source"-field in the recent FLEXIcontent Universal Module.
Is there any reason for removing it from the module or is there another workaroud I've maybe not seen?

Regards

Please Log in or Create an account to join the conversation.

mcmurdok
Topic Author
Offline
Senior Member

13 years 10 months ago #23638 by mcmurdok

Replied by mcmurdok on topic [solved] Where is the Custom Image Source

I've found the bug.
In the file mod_flexicontent.xml in line 249 and 251 it has to be "<field name= ... />"
instead of "<param name= ... />"

I'll test it.

Regards

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 10 months ago #23640 by ggppdk

Replied by ggppdk on topic [solved] Where is the Custom Image Source

Actually this has been improved !!!

We have 2 parameters now

1. Field HTML as Image
2. Field URL as Image

The first one is what you need (read descriptions) :

-- in Field HTML as Image you can add the HTML of any field e.g. myfield##display

the code of the field will be enter "unchanged" as the "image"

in Field URL as Image , e.g. myfield##url1

the field variable must contain an image url which will be used for outputing an image

Regards

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star review. Thanks!

Please Log in or Create an account to join the conversation.

mcmurdok
Topic Author
Offline
Senior Member

13 years 10 months ago #23642 by mcmurdok

Replied by mcmurdok on topic [solved] Where is the Custom Image Source

Thank you.
Did you see, that there is a bug in the mod_flexicontent.xml in line 249 and 251?
After changing it from "param" to "field" I saw the new improved fields.

Great component and univeral module!!
Regards

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 10 months ago #23645 by ggppdk

Replied by ggppdk on topic [solved] Where is the Custom Image Source

aaa , this was implemented in J1.5 and then added to J2.5 i missed updating <param ...> to <field ...>

also do same for parameters at :

442,445 and 494,497 (about read more of categories)

thanks for reporting

will commit today with other fixes

Please Log in or Create an account to join the conversation.

mcmurdok
Topic Author
Offline
Senior Member

13 years 10 months ago #23676 by mcmurdok

Replied by mcmurdok on topic [solved] Where is the Custom Image Source

After testing the "Field HTML as Image" I recognized, that the $item->image_rendered
on a fresh intalled J2.5.3 and FC2.0, RC4 1209 gives back an correct pure image-URL (source of the large image by custom: imgfield##display_large) as it should.

My project-site of Joomla(2.5.3) where I installed the new RC4 over the RC2 renders a comlete <img>-HTML-tag, but always the middle-format, indepent from the custom code e.g. imgfield##display_large.

Is it possible, that there are any database-changes, which cause the different behavior in rendering?
Very strange, because the relevant php-files are the same
(mod_flexicontent/helper.php, mod_flexicontent/tmpl/news/news.php, plugins/flexicontent_fields/image/image.php) and also the preferences.

Regards

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

13 years 10 months ago #23732 by ggppdk

Replied by ggppdk on topic [solved] Where is the Custom Image Source

image field is bogus, it incorrectly ovewrittes the contents of $field->{"display_large"} with the contents of $field->{"display"} when asked to only create $field->{"display_large"} !!!

So open image.php and

replace

Code:

$field->{"display_small"} = JURI::root() . $srcs;
$field->{"display_medium"} = JURI::root() . $srcm;
$field->{"display_large"} = JURI::root() . $srcb;

with

Code:

$field->{"display_small_src"} = JURI::root().$srcs;
	$field->{"display_medium_src"} = JURI::root().$srcm;
	$field->{"display_large_src"} = JURI::root().$srcb;
	$field->{"display_small"} = '<img src="'.JURI::root().$srcs.'" alt ="'.$alt.'"'.$legend.' />';
	$field->{"display_medium"} = '<img src="'.JURI::root().$srcm.'" alt ="'.$alt.'"'.$legend.' />';
	$field->{"display_large"} = '<img src="'.JURI::root().$srcb.'" alt ="'.$alt.'"'.$legend.' />';
	if ( in_array($prop, array("display_small","display_medium", "display_large", "display_small_src","display_medium_src", "display_large_src") ) ) {
		return $field->{$prop};
	}

will commit fix, thanks for reporting.

A NOTE on appropriate field behavior ..., when a field is asked a specific HTML display, then it must only render this display to enhance performance, sometimes a field can create multiple displays if they do not involve performance hit, e.g. when asked for "display" , it could also create other variables that pose no performance hit e.g. variables that contain some html like display_*

Please Log in or Create an account to join the conversation.