[SOLVED, already in latest release] Missing colon causing JS issues

jderrick
Topic Author
Offline
New Member

7 years 5 months ago - 7 years 5 months ago #64727 by jderrick

[SOLVED, already in latest release] Missing colon causing JS issues was created by jderrick

With a different extension I added some JS to the head of a template using the standard Joomla method.

Unfortunately this broke the JS. I tracked down the issue to line 299 of components/com_flexicontent/flexicontent.php where this script declaration is added:

Code:

$js = 'var fc_validateOnSubmitForm = 1';
$document->addScriptDeclaration( $js );

This issue here is that the 1 is not followed by a colon meaning any further Javascript added to the head becomes broken. Please add a colon to the next release so my core code hack/fix is not overwritten!

Jamie

Last edit: 7 years 5 months ago by ggppdk.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

7 years 5 months ago #64728 by ggppdk

Replied by ggppdk on topic Missing colon causing JS issues

Hello

you have previous FLEXIcontent version, maybe you have v3.1.0-rc2

the missing colon has been added in latest official release:
v3.1.0

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

7 years 5 months ago #64729 by ggppdk

Replied by ggppdk on topic Missing colon causing JS issues

Hello

but of course: thanks for reporting

issue reports,
- that also point to the specific code that creates the issue,
are very welcome

Please Log in or Create an account to join the conversation.

jderrick
Topic Author
Offline
New Member

7 years 5 months ago #64730 by jderrick

Replied by jderrick on topic [SOLVED, already in latest release] Missing colon causing JS issues

Fantastic. Thanks!

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

7 years 5 months ago #64731 by ggppdk

Replied by ggppdk on topic [SOLVED, already in latest release] Missing colon causing JS issues

Hello

- also v3.1.0 now get an update-site URL in joomla extension update checks
Thus you will get notified of new stable releases more easily (even if you have disabled the update check at FLEXIcontent backend dashboard)
- also a language package screen
- a long list of features and has finished the revising of backend UI configuration screens

v3.1.0 is more solid release, with only a few small bugs have been addressed already and v3.1.1 is ready and being tested

- no new features in v3.1.1 just a few bug fixes

Please Log in or Create an account to join the conversation.